-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VSelect): port to v3 #14504
feat(VSelect): port to v3 #14504
Conversation
4d6f328
to
aa88c96
Compare
d016651
to
c617b3e
Compare
5acb95a
to
5d79992
Compare
ed5fdfb
to
55b990f
Compare
beccc1d
to
575e070
Compare
cf9ad5d
to
b7f24c5
Compare
added disabled/error states to v-field added hint / persistentHint to v-text-field removed hint and focus props from v-input
c968024
to
9022b2d
Compare
<template>
<v-app>
<v-main>
<v-select :items="['a', 'b', 'c']" prepend-icon="mdi-vuetify" clearable @click:prepend="c" />
</v-main>
</v-app>
</template>
<script setup>
const c = e => console.log(e)
</script>
|
|
Could be done with different property name, ex. |
packages/vuetify/src/components/VPagination/__tests__/VPagination.spec.cy.tsx
Show resolved
Hide resolved
packages/vuetify/src/components/VTextarea/__tests__/VTextarea.spec.cy.tsx
Show resolved
Hide resolved
inputRef.value?.focus() | ||
} | ||
|
||
if (!isFocused.value) isFocused.value = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KNOWN ISSUES:
v-textarea
auto-grow does not workv-fileinput
loses focus when opening folder selection dialogDescription
Ported v-select component using v-text-field as a baseline. Updated multiple functionality and design aspects of supporting input components (VInput, VField) to ensure a seamless transition between different options. Specific changes include:
VTextField
VField
VInput
Motivation and Context
Implement the v-select component
How Has This Been Tested?
n/a
Markup:
https://www.toptal.com/developers/hastebin/uvifabekey.xml
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).